To my ear, thousands upon thousands could just mean “severe thousands” or “many thousands”.

What would amount to millions if someone would say thousands of thousands (not thousands if there were no dollars)?